Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add required title parameter to message command #34465

Merged
merged 2 commits into from
Sep 18, 2024
Merged

docs: add required title parameter to message command #34465

merged 2 commits into from
Sep 18, 2024

Conversation

lfdominguez
Copy link
Contributor

Why:

Message command example does not comply with the required parameters table.

Closes:
#34450

What's being changed (if available, include any code snippets, screenshots, or gifs):

Add the required title parameter to message command examples

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

  • For content changes, I have completed the self-review checklist.

@welcome Welcome
Copy link

welcome bot commented Sep 2, 2024

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Sep 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 2, 2024 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/writing-workflows/choosing-what-your-workflow-does/workflow-commands-for-github-actions.md fpt
ghec
ghes@ 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.14 3.13 3.12 3.11 3.10

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team and removed triage Do not begin working on this issue until triaged by the team labels Sep 2, 2024
@nguyenalex836
Copy link
Contributor

@lfdominguez Thank you for opening this PR! ✨ Can you update your PR to match @subatoi's comment -

Please use our placeholder format as follows:

title=YOUR-TITLE

We'll be happy to review again once this is complete 💛

@nguyenalex836 nguyenalex836 added the more-information-needed More information is needed to complete review label Sep 2, 2024
@subatoi subatoi mentioned this pull request Sep 3, 2024
Closed
1 task
@subatoi subatoi added the Review on hold Discussions on the best resolution are in progress, do not merge label Sep 3, 2024
@nguyenalex836 nguyenalex836 removed the more-information-needed More information is needed to complete review label Sep 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

A stale label has been added to this pull request because it has been open 7 days with no activity. To keep this PR open, add a comment or push a commit within 3 days.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Sep 10, 2024
@github-actions github-actions bot closed this Sep 10, 2024
@nguyenalex836 nguyenalex836 reopened this Sep 10, 2024
@nguyenalex836 nguyenalex836 removed the stale There is no recent activity on this issue or pull request label Sep 10, 2024
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Sep 10, 2024
@nguyenalex836 nguyenalex836 removed the triage Do not begin working on this issue until triaged by the team label Sep 10, 2024
Stephaniecheree referenced this pull request Sep 11, 2024
@Octomerger
Merge pull request #26103 from github/repo-sync
d2e719d 
Repo sync
@github-actions GitHub Actions
Copy link
Contributor

A stale label has been added to this pull request because it has been open 7 days with no activity. To keep this PR open, add a comment or push a commit within 3 days.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Sep 18, 2024
@github-actions github-actions bot closed this Sep 18, 2024
@nguyenalex836 nguyenalex836 reopened this Sep 18, 2024
@nguyenalex836 nguyenalex836 removed the stale There is no recent activity on this issue or pull request label Sep 18, 2024
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Sep 18, 2024
@nguyenalex836 nguyenalex836 removed the triage Do not begin working on this issue until triaged by the team label Sep 18, 2024
jc-clark
jc-clark approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@jc-clark jc-clark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this update @lfdominguez! I'll go ahead and merge.

@jc-clark jc-clark added this pull request to the merge queue Sep 18, 2024
Merged via the queue into github:main with commit 564303d Sep 18, 2024
150 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jc-clark jc-clark jc-clark approved these changes

Assignees
No one assigned
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team Review on hold Discussions on the best resolution are in progress, do not merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lfdominguez @nguyenalex836 @jc-clark @subatoi