Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add more details to secret output in GitHub Actions #34555

Merged
merged 2 commits into from
Sep 16, 2024
Merged

docs: Add more details to secret output in GitHub Actions #34555

merged 2 commits into from
Sep 16, 2024

Conversation

gonmmarques
Copy link
Contributor

Why:

Closes: #34216

What's being changed (if available, include any code snippets, screenshots, or gifs):

As per the #34216, this includes the current message from the runner when skipping the outputting of a secret and linking to doc on how to handle it.

Feel free to improve the wording.

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

  • For content changes, I have completed the self-review checklist.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Sep 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 10, 2024 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/writing-workflows/choosing-what-your-workflow-does/passing-information-between-jobs.md fpt
ghec
ghes@ 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.14 3.13 3.12 3.11 3.10
from reusable
actions/writing-workflows/workflow-syntax-for-github-actions.md fpt
ghec
ghes@ 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.14 3.13 3.12 3.11 3.10
from reusable

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Sep 10, 2024
@nguyenalex836
Copy link
Contributor

@gonmmarques Thanks so much for opening a PR! I'll get this triaged for review ✨

@nguyenalex836
Copy link
Contributor

@gonmmarques Thank you so much for opening a PR with this fix! ✨ This repo is currently in a code freeze, but we will get this merged as soon as the freeze ends on 9/16 🍏

@nguyenalex836 nguyenalex836 added ready to merge This pull request is ready to merge and removed waiting for review Issue/PR is waiting for a writer's review labels Sep 10, 2024
@nguyenalex836 nguyenalex836 added this pull request to the merge queue Sep 16, 2024
Merged via the queue into github:main with commit dbfc6cf Sep 16, 2024
42 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@gonmmarques gonmmarques deleted the docs/improve-secret-in-actions branch September 16, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nguyenalex836 nguyenalex836 nguyenalex836 approved these changes

Assignees
No one assigned
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Talk about Warning: Skip output 'secret' since it may contain secret.
2 participants
@gonmmarques @nguyenalex836