-
Notifications
You must be signed in to change notification settings - Fork 83k
Update Unity template #4738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Habetdin
wants to merge
12
commits into
github:main
Choose a base branch
from
Habetdin:unity
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update Unity template #4738
+46
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add debug data directories entry Add OBB (Opaque Binary Blob) files entry
Use explicit directory paths (add trailing slash) Use explicit `name` + `name.meta` pairs instead of `name*`
Use explicit directory paths (add trailing slash)
Add PerformanceTestRun files entries Remove duplicate InitTestScene entry
Ignore Gradle backup setting files Ignore Gradle local.properties
Make pattern more explicit (include Assets directory prefix)
Ignore TouchDesigner cache files They are generated during 3D models editing
Unity Editor creates backup files on crash and places them in Assets/_Recovery directory
@wirecat just FYI: the d0c6a25 commit has merged: Lines 79 to 80 in fc6ce5d
which is a duplicate-ish of previous: Lines 98 to 99 in fc6ce5d
This PR replaces both with more explicit rule ( Lines 104 to 105 in ae35063
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
This PR tidies up the existing Unity template and adds multiple new Unity-related patterns.
Normalization is achieved by:
name
+name.meta
pattern pairs instead of wildcardname*
patternsAssets/
directory prefix to make pattern more explicit/[Mm]emoryCaptures/
to/[Mm]emory[Cc]aptures/
for uniformityLinks to documentation supporting these rule changes
New patterns were added for the following:
Builds
Mono
Mono produces files which are not always cleaned up (e.g. after crashes):
Test Framework
InitTestScene*.unity
entryOther
Assets/GeneratedLocalRepo/
directory (EDM4U is External Dependency Manager for Unity)mainTemplate.gradle.backup
,mainTemplate.gradle.backup2
, etc.)Assets/_Recovery/
directory - Unity Editor creates backup files after crashMerge and Approval Steps