Fix DoesErase to additionally assert that a source must be erased if the default is selected (no case is selected). Otherwise, the select cannot replace the source because the default expression isn't guaranteed to be equal to the source. #3164
+68
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f3bf605 to
8d48fbd
Compare
…the default is selected (no case is selected). Otherwise, the select cannot replace the source because the default expression isn't guaranteed to be equal to the source. PiperOrigin-RevId: 817236514
8d48fbd to
c3ec588
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix DoesErase to additionally assert that a source must be erased if the default is selected (no case is selected). Otherwise, the select cannot replace the source because the default expression isn't guaranteed to be equal to the source.