Add gen-stringify-test.go #1196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
friendly ping @gauntface |
gauntface
approved these changes
Jun 20, 2019
github/gen-stringify-test.go
Outdated
| var ( | ||
| verbose = flag.Bool("v", false, "Print verbose log messages") | ||
|
|
||
| sourceTmpl = template.Must(template.New("source").Funcs(funcMap).Parse(source)) |
There was a problem hiding this comment.
Nit: could you move this to after the definition of funcMap.
|
Thank you, @gauntface! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After looking at the coverage details here: https://codecov.io/gh/google/go-github/tree/master/github
and noticing that the
Stringmethods account for a non-trivial percentage of uncovered code, I decided to write some.Then, after writing a couple tests by hand, I realized that this is another great opportunity for
go generateto write this mundane code for us and put it in a test file that nobody needs to care or worry about (github-stringify_test.go).Getting these trivial functions out of the way, I believe that the coverage details will now have more meaning and we can more clearly identify and focus our attention on methods that need better test coverage.