Codecov Report

Merging #2036 (565a992) into master (7b61934) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2036   +/-   ##
=======================================
  Coverage   97.87%   97.87%           
=======================================
  Files         107      107           
  Lines        6907     6907           
=======================================
  Hits         6760     6760           
  Misses         81       81           
  Partials       66       66           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b61934...565a992. Read the comment docs.

The GitHub v3 API docs for this endpoint state:

You can only provide a list of repository ids when the visibility is set to selected.

Am I reading this correctly that this endpoint should simply not be called when visibility is set to some other value?

I ask because I'm trying to figure out if there is any case when you would want to call this endpoint but NOT send a value for selected_repository_ids ?

Yes - this endpoint should simply not be called when visibility is not selected, otherwise the following error will be returned:

"errors": "You cannot update selected repositories for a secret when the visibility is not set to 'selected'",

My use case for calling this endpoint without sending a value for selected_repository_ids is to set selected repository list to empty. However like I mentioned above I'll send over an empty array instead of nil or something else.

Thanks @gmlewis , may I request a release for this change?

Sure, I'll get you a release.

Here you go, @xun-guo-anzx - https://github.com/google/go-github/releases/tag/v38.1.0