Skip to content

feat: generate release notes support #2114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 12, 2021
Merged

feat: generate release notes support #2114

merged 4 commits into from
Oct 12, 2021

Conversation

caarlos0
Copy link
Contributor

@caarlos0 caarlos0 commented Oct 5, 2021 •
edited
Loading

supports the new feature github announced today: generate release notes (link)

while there are no official docs yet, one of the product managers posted screenshots of it on twitter: https://twitter.com/MylesBorins/status/1445102641214861318

This implements both the new /releases/generate-notes endpoint and the new generate_release_notes release option.

@caarlos0
feat: generate release notes support
87fa53e 
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@google-cla google-cla bot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Oct 5, 2021
@caarlos0 caarlos0 mentioned this pull request Oct 5, 2021
Closed
@codecov
Copy link

codecov bot commented Oct 5, 2021 •
edited
Loading

Codecov Report

Merging #2114 (2b34cb0) into master (3ad22bc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2114   +/-   ##
=======================================
  Coverage   97.78%   97.78%           
=======================================
  Files         112      112           
  Lines        9956     9970   +14     
=======================================
+ Hits         9735     9749   +14     
  Misses        154      154           
  Partials       67       67
Impacted Files Coverage Δ
github/repos_releases.go 89.40% <100.00%> (+0.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ad22bc...2b34cb0. Read the comment docs.

gmlewis
gmlewis requested changes Oct 5, 2021
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @caarlos0 !
Just a few minor tweaks, please.

Also, to clarify, you can drop the omitempty and the pointer to a field if you know they are absolutely mandatory.

@caarlos0
fix: required fields
1cb1c51 
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@caarlos0
fix: go generate
6432493 
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@caarlos0
Copy link
Contributor Author

caarlos0 commented Oct 5, 2021

Thanks for the review @gmlewis! Just fixed the based on this tweet.

gmlewis
gmlewis reviewed Oct 5, 2021
View reviewed changes
@caarlos0
fix: PreviousTagName
2b34cb0 
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
gmlewis
gmlewis approved these changes Oct 5, 2021
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @caarlos0 !
LGTM.

Awaiting second LGTM (from any other contributor to this repo) before merging.

@gmlewis gmlewis requested a review from wesleimp October 5, 2021 04:07
@caarlos0
Copy link
Contributor Author

can someone else review/merge this?

@gmlewis
Copy link
Collaborator

gmlewis commented Oct 12, 2021

@Parker77 - do you have time to review this?

Parker77
Parker77 approved these changes Oct 12, 2021
View reviewed changes
Copy link

@Parker77 Parker77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gmlewis
Copy link
Collaborator

gmlewis commented Oct 12, 2021

LGTM.

Thank you, @Parker77!
Merging.

@gmlewis gmlewis merged commit d1858a3 into google:master Oct 12, 2021
@neilgierman neilgierman mentioned this pull request May 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmlewis gmlewis gmlewis approved these changes

@wesleimp wesleimp Awaiting requested review from wesleimp

+1 more reviewer

@Parker77 Parker77 Parker77 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caarlos0 @gmlewis @Parker77