-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Document upcoming changes to events payload #3667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
feat: Add deprecation notices for AuthorAssociation field in various event types
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3667 +/- ##
=======================================
Coverage 91.23% 91.23%
=======================================
Files 185 185
Lines 16421 16421
=======================================
Hits 14982 14982
Misses 1254 1254
Partials 185 185 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @romanywu!
LGTM.
Awaiting second LGTM+Approval from any other contributor before merging.
@alexandear or @stevehipwell - might one of you be available for a code review? Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove (Issue #3665)
from PR's title and add Closes #3665
to description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @romanywu this looks really good, just waiting on the PR changes @alexandear asked for before I approve.
@gmlewis if you want to get this merged you should be able to update the title and PR body.
✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you, @romanywu, @alexandear, and @stevehipwell! |
Closes #3665