Skip to content

Conversation

roman-y-wu
Copy link
Contributor

@roman-y-wu roman-y-wu commented Aug 11, 2025

Closes #3665

feat: Add deprecation notices for AuthorAssociation field in various event types
Copy link

google-cla bot commented Aug 11, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

codecov bot commented Aug 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.23%. Comparing base (84a0945) to head (2640f20).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3667   +/-   ##
=======================================
  Coverage   91.23%   91.23%           
=======================================
  Files         185      185           
  Lines       16421    16421           
=======================================
  Hits        14982    14982           
  Misses       1254     1254           
  Partials      185      185           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmlewis gmlewis changed the title Upcoming changes to events payload (Issue #3665) Document upcoming changes to events payload (Issue #3665) Aug 12, 2025
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @romanywu!
LGTM.

Awaiting second LGTM+Approval from any other contributor before merging.

@alexandear or @stevehipwell - might one of you be available for a code review? Thank you!

Copy link
Contributor

@alexandear alexandear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove (Issue #3665) from PR's title and add Closes #3665 to description.

Copy link
Contributor

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @romanywu this looks really good, just waiting on the PR changes @alexandear asked for before I approve.

@gmlewis if you want to get this merged you should be able to update the title and PR body.

@roman-y-wu roman-y-wu changed the title Document upcoming changes to events payload (Issue #3665) Document upcoming changes to events payload Aug 12, 2025
@roman-y-wu
Copy link
Contributor Author

Please remove (Issue #3665) from PR's title and add Closes #3665 to description.

Copy link
Contributor

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis
Copy link
Collaborator

gmlewis commented Aug 12, 2025

Thank you, @romanywu, @alexandear, and @stevehipwell!
Merging.

@gmlewis gmlewis merged commit 2eec208 into google:master Aug 12, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upcoming changes to events payload
4 participants