fix: Replace 'organizations' with 'orgs' in API endpoints #3673
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates GitHub API endpoint URLs to replace 'organizations' with 'orgs' in organization-related actions permissions endpoints, following a recent GitHub API change.
- Updates OpenAPI operations metadata to reflect the new endpoint format
- Modifies Go code to use the new
/orgs/{org}/endpoint format instead of/organizations/{org}/ - Updates corresponding test files to match the new endpoint URLs
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| openapi_operations.yaml | Removes old /organizations/{org}/ endpoints and adds new /orgs/{org}/ endpoints for actions permissions |
| github/actions_permissions_orgs.go | Updates URL construction to use /orgs/ prefix instead of /organizations/ |
| github/actions_permissions_orgs_test.go | Updates test mock handlers to use new endpoint URLs |
|
As I mentioned here, maintainers typically update the auto-generated But just to confirm, did you update this against the public GitHub site (OK), or against an enterprise installation of GitHub (not OK)? |
|
OK, I'm seeing what you are seeing, so we will proceed with this PR. Thank you, @zyfy29! What I'm amazed at, though, is how GitHub can make a breaking change like this without an announcement... although maybe I simply missed the announcement. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3673 +/- ##
=======================================
Coverage 91.23% 91.23%
=======================================
Files 185 185
Lines 16421 16421
=======================================
Hits 14982 14982
Misses 1254 1254
Partials 185 185 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@gmlewis I just checked both public and enterprise version documentation, and to be honest I didn't check is there any announcemen. But thank you for your confirmation! |
As noticed #3671 (comment), it seems that github changed some organizations api endpoints in the two days.
I just fixed my implement yesterday, then did
script/metadata.sh update-openapito follow the change.