feat: Add GitHub Classroom GetAssignment API endpoint #3685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Add GitHub Classroom GetAssignment API endpoint
Implements `GET /assignments/{assignment_id}` endpoint for retrieving GitHub Classroom assignment details.
## Changes
- **New service**: `ClassroomService` with `GetAssignment()` method
- **New structs**: `Assignment` (19 fields) and `Classroom` with organization details
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3685 +/- ##
=======================================
Coverage 91.07% 91.08%
=======================================
Files 186 187 +1
Lines 16563 16581 +18
=======================================
+ Hits 15085 15103 +18
Misses 1293 1293
Partials 185 185 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gmlewis
approved these changes
Aug 17, 2025
There was a problem hiding this comment.
Thank you, @jferrl!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
@alexandear or @stevehipwell - might you have time for a code review? Thank you!
Refactors the Assignment struct and related methods to ClassroomAssignment for improved clarity and consistency. Updates all accessors, service methods, and tests to use the new name.
|
Thank you, @stevehipwell! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
GET /assignments/{assignment_id}endpoint for retrieving GitHub Classroom assignment details.Changes
ClassroomServicewithGetAssignment()methodClassroomAssignmentandClassroomwith organization detailsIssue #3684