Allow brush tips to have multiple outlines (e.g. for particle effects) #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cd1c1f0 to
0d157aa
Compare
In `StrokeShapeBuilder`, this involves losing the assumption that the number of outlines is exactly equal to the number of brush tips, since particle brushes have more than one outline per tip. Without that assumption, it can also discard empty outlines a bit earlier.
In `BrushTipExtruder` this involves:
* Keeping a vector of outlines instead of a single outline (since the usual case is just one, this uses `absl::InlinedVector<StrokeOutline, 1>`).
* Keep track of the number of extrusion breaks in `Geometry`.
* Add accessors to `Geometry` to get the number of break-points and the index counts at the lastest break-point. Use those in `Restore` to restore the saved state and in `AppendNewIndices` to get the start points in the latest outline.
* Pull calls to `AppendNewIndices` and `Geometry::UpdateMeshDerivatives` into `ExtrudeBreakPoint` because the former computes the latest outline and the latter may update indices, so it needs to be called first.
* Similarly, move forward the "first mutated" indices in `Geometry::AddExtrusionBreak`, since those track the first mutated vertices that haven't been recorded in the outline. These are renamed to `first_mutated_{left,right}_index_offset_in_current_partition_`, since these no longer track the same thing as `first_mutated_left_index_` and `first_mutated_right_index_` (which still considers a whole stroke update).
In `InProgressStroke`, `GetIndexOutlines` is renamed to `GetCoatOutlines` for clarity, since that makes it clear what the index is referring to.
PiperOrigin-RevId: 703187544
0d157aa to
ce4c535
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow brush tips to have multiple outlines (e.g. for particle effects)
In
StrokeShapeBuilder, this involves losing the assumption that the number of outlines is exactly equal to the number of brush tips, since particle brushes have more than one outline per tip. Without that assumption, it can also discard empty outlines a bit earlier.In
BrushTipExtruderthis involves:Keeping a vector of outlines instead of a single outline (since the usual case is just one, this uses
absl::InlinedVector<StrokeOutline, 1>).Keep track of the number of extrusion breaks in
Geometry.Add accessors to
Geometryto get the number of break-points and the index counts at the lastest break-point. Use those inRestoreto restore the saved state and inAppendNewIndicesto get the start points in the latest outline.Pull calls to
AppendNewIndicesandGeometry::UpdateMeshDerivativesintoExtrudeBreakPointbecause the former computes the latest outline and the latter may update indices, so it needs to be called first.Similarly, move forward the "first mutated" indices in
Geometry::AddExtrusionBreak, since those track the first mutated vertices that haven't been recorded in the outline. These are renamed tofirst_mutated_{left,right}_index_offset_in_current_partition_, since these no longer track the same thing asfirst_mutated_left_index_andfirst_mutated_right_index_(which still considers a whole stroke update).In
InProgressStroke,GetIndexOutlinesis renamed toGetCoatOutlinesfor clarity, since that makes it clear what the index is referring to.