Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OboeTester: Test both with and without Oboe SRC in test disconnect #1964

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

robertwu1
Copy link
Collaborator

@robertwu1 robertwu1 commented Feb 16, 2024

Tests 44100 both with and without Oboe SRC.

@robertwu1 robertwu1 requested review from flamme and philburk February 16, 2024 22:07
Copy link
Collaborator

@philburk philburk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this test was added because sample rate conversion in oboe makes use of a kind of proxy filter object. At one point the error callback was not being propagated properly from the proxy to the main application object. So disconnect was failing. This tests a feature of oboe. So we should keep it.

But if we want to check to make sure that sample rate conversion in aaudio does not break the error callbacks, then we should make another sample rate conversion test that uses the oboe sample rate conversion quality of none. Then AAudio will do the conversion.

@robertwu1 robertwu1 changed the title OboeTester: Remove sample rate conversion in test disconnect OboeTester: Test both with and without Oboe SRC in test disconnect Feb 20, 2024
@robertwu1 robertwu1 requested a review from philburk February 20, 2024 18:55
@robertwu1
Copy link
Collaborator Author

I believe this test was added because sample rate conversion in oboe makes use of a kind of proxy filter object. At one point the error callback was not being propagated properly from the proxy to the main application object. So disconnect was failing. This tests a feature of oboe. So we should keep it.

But if we want to check to make sure that sample rate conversion in aaudio does not break the error callbacks, then we should make another sample rate conversion test that uses the oboe sample rate conversion quality of none. Then AAudio will do the conversion.

Let me know if the newest iteration looks ok to you. It does both now.

@robertwu1 robertwu1 merged commit 24004f8 into main Feb 21, 2024
3 checks passed
@robertwu1 robertwu1 deleted the robertwu/testdisconnectremovesrc branch February 21, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants