Correctly handle nullable type arguments in a number of APIs #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
04357d8
to
b080810
Compare
kevmoo
commented
Nov 15, 2022
| @@ -151,7 +151,7 @@ class HashBiMap<K, V> implements BiMap<K, V> { | |||
| @override | |||
| void updateAll(V Function(K key, V value) update) { | |||
| for (final key in keys) { | |||
| _add(key, update(key, _map[key]!), true); | |||
| _add(key, update(key, _map[key] as V), true); | |||
There was a problem hiding this comment.
handles the nullable V case correctly!
This could also iterate over entries to avoid the as check...
kevmoo
commented
Nov 15, 2022
| @@ -290,7 +290,7 @@ class LinkedLruHashMap<K, V> implements LruMap<K, V> { | |||
| V update(K key, V Function(V value) update, {V Function()? ifAbsent}) { | |||
| V newValue; | |||
| if (containsKey(key)) { | |||
| newValue = update(this[key]!); | |||
| newValue = update(this[key] as V); | |||
There was a problem hiding this comment.
No way around this, if I understand things correctly
yjbanov
approved these changes
Nov 16, 2022
| @@ -23,7 +23,7 @@ import 'dart:collection'; | |||
| /// With the introduction of non-null by default in Dart SDK 2.12, developers | |||
| /// should avoid adding more uses of this type. Existing users should migrate | |||
| /// away from the `Optional` type to types marked nullable: `T?`. | |||
| class Optional<T> extends IterableBase<T> { | |||
| class Optional<T extends Object> extends IterableBase<T> { | |||
There was a problem hiding this comment.
This is probably breaking, but if you can pull this through, hats off to you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.