Skip to content

Conversation

danieljbruce
Copy link
Contributor

To get one of the specific test cases passing for readRow, we need a slight fix to the way returned data is parsed.

@danieljbruce danieljbruce requested review from a team as code owners February 1, 2023 19:31
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigtable Issues related to the googleapis/nodejs-bigtable API. labels Feb 1, 2023
@ruyadorno
Copy link
Contributor

it'd be nice for the commit message to mention that this is related to the test proxy and not the implementation itself 😊 maybe prepend testproxy: to the title?

Copy link
Contributor

@ruyadorno ruyadorno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@danieljbruce
Copy link
Contributor Author

it'd be nice for the commit message to mention that this is related to the test proxy and not the implementation itself 😊 maybe prepend testproxy: to the title?

Unfortunately for the conventional commits to pass we must prefix with a specific word. Probably test: in this case.

https://www.conventionalcommits.org/en/v1.0.0/

Maybe set to test: testproxy: Slight change in data returned by readRow?

@danieljbruce danieljbruce changed the title Slight change in data returned by readRow test: testproxy: Slight change in data returned by readRow Feb 1, 2023
@conventional-commit-lint-gcf
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@ruyadorno
Copy link
Contributor

ruyadorno commented Feb 1, 2023

maybe we can use: test(testproxy): read row should return a single row so that it's also a bit more descriptive of the change

maybe even chore(testproxy): since the test proxy is not a direct test and rather an util for running the e2e tests

@ruyadorno
Copy link
Contributor

for reference, I used chore in the commit I introduced the testproxy, ref: 0b3d996

@danieljbruce danieljbruce changed the title test: testproxy: Slight change in data returned by readRow chore(testproxy): read row should return a single row Feb 1, 2023
@danieljbruce danieljbruce added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 1, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 1, 2023
@danieljbruce danieljbruce merged commit 1ccbfe6 into googleapis:main Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/nodejs-bigtable API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants