-
Notifications
You must be signed in to change notification settings - Fork 62
chore(testproxy): read row should return a single row #1230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(testproxy): read row should return a single row #1230
Conversation
it'd be nice for the commit message to mention that this is related to the test proxy and not the implementation itself 😊 maybe prepend |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Unfortunately for the conventional commits to pass we must prefix with a specific word. Probably https://www.conventionalcommits.org/en/v1.0.0/ Maybe set to |
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
maybe we can use: maybe even |
for reference, I used |
To get one of the specific test cases passing for readRow, we need a slight fix to the way returned data is parsed.