Skip to content

Allow Start to be called immediately after Stop #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 3, 2020
Merged

Allow Start to be called immediately after Stop #19

merged 2 commits into from
Jan 3, 2020

Conversation

genevieve
Copy link

  • Prior to this change the library would panic if you called Start a
    second time immediately after calling Stop
  • This change updates Stop to block until the background Listen method is
    finished

cc @ljfranklin

@genevieve genevieve changed the title Allow Start to be called immediately after Stop [WIP] Allow Start to be called immediately after Stop Dec 4, 2018
@ljfranklin
Allow Start to be called immediately after Stop
921d4ab 
- Prior to this change the library would panic if you called Start a
  second time immediately after calling Stop
- This change updates Stop to block until the background Listen method is
  finished

Signed-off-by: Genevieve Lesperance <glesperance@pivotal.io>
@genevieve genevieve changed the title [WIP] Allow Start to be called immediately after Stop Allow Start to be called immediately after Stop Dec 4, 2018
@ljfranklin ljfranklin mentioned this pull request Dec 10, 2018
Merged
@asahasrabuddhe asahasrabuddhe merged commit 11a6ee7 into gosuri:master Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@genevieve @asahasrabuddhe @ljfranklin