Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alerting: Use cloud notifier types for metadata on Cloud AMs #91054

Merged
merged 4 commits into from
Aug 2, 2024

Conversation

tomratcliffe
Copy link
Member

@tomratcliffe tomratcliffe commented Jul 26, 2024

What is this feature?

Uses the hardcoded cloud notifier types as metadata for displaying contact points for cloud alertmanagers

Why do we need this feature?

Richer display in the UI for external AMs

Who is this feature for?

Alerting users

Before:
Screenshot 2024-07-26 at 14 39 06

After:
Screenshot 2024-07-26 at 14 39 08

@tomratcliffe
Copy link
Member Author

(fixed email display for cloud AM now)
image

@tomratcliffe tomratcliffe force-pushed the alerting/contact-point-metadata-cloud-am branch from 4b6307c to a237f89 Compare July 30, 2024 12:50
@tomratcliffe tomratcliffe marked this pull request as ready for review July 30, 2024 12:51
@tomratcliffe tomratcliffe requested a review from a team as a code owner July 30, 2024 12:51
@tomratcliffe tomratcliffe requested review from gillesdemey, konrad147 and soniaAguilarPeiron and removed request for a team July 30, 2024 12:51
@github-actions github-actions bot added this to the 11.2.x milestone Jul 30, 2024
@tomratcliffe tomratcliffe merged commit 1d96cd8 into main Aug 2, 2024
15 checks passed
@tomratcliffe tomratcliffe deleted the alerting/contact-point-metadata-cloud-am branch August 2, 2024 09:30
giorgioatmerqury pushed a commit to cybermerqury/grafana that referenced this pull request Aug 21, 2024
@aangelisc aangelisc modified the milestones: 11.2.x, 11.2.0 Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants