Skip to content

Commit

Permalink
Add monaco-graphql special wg minutes (#2203)
Browse files Browse the repository at this point in the history
  • Loading branch information
acao authored Feb 23, 2022
1 parent 5f63d8e commit 7206e6d
Showing 1 changed file with 32 additions and 0 deletions.
32 changes: 32 additions & 0 deletions working-group/agendas/2022-22-02-monaco.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
## Ad-Hoc `monaco-graphql` WG pairing session re: SDL editing

### In Attendance

- [@cshaver](github.com/cshaver)
- [@acao](github.com/acao)


### Agenda

- Review bugs with an SDL editing implementation of `monaco-graphql`
- Determine what RFCs we can present to make this problem easier to solve

### Minutes

we looked at:
- confirmed on the latest vite example, too many workers is triggered by schema changes
- look at how schema is shared with the worker, since this can change often
- e.g. innoDB, cache api

found some bugs:
- (monaco-editor) bg missing on autocomplete box - need to create a bug ticket for them!
- repro'd https://github.com/graphql/graphiql/pull/2171/files
- monaco-react webpack example has some bugs that vite doesn't
- would be cool to get a basic cypress test (get model markers from monaco), visual diff testing
- (monaco?) lots of logs from monarchCommon on parsing directives
- improve webpack example config, so the web workers output name aren't hashed
- devx of running examples from root maybe: `yarn run example:<example name>`

### Recording

https://www.dropbox.com/s/scsdezmvwor1ico/wholeaugustsoptfree%20on%202022-02-22%2020-13.mp4?dl=0

0 comments on commit 7206e6d

Please sign in to comment.