support for template strings with replacement expressions #2111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3aa6c6d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest changes of this PR are available as canary in npm (based on the declared |
Codecov Report
@@ Coverage Diff @@
## main #2111 +/- ##
==========================================
- Coverage 65.70% 64.78% -0.93%
==========================================
Files 85 77 -8
Lines 5106 5185 +79
Branches 1631 1654 +23
==========================================
+ Hits 3355 3359 +4
- Misses 1747 1822 +75
Partials 4 4
Continue to review full report at Codecov.
|
1d59e2a
to
48a44d9
Compare
this adds support for template strings with variable replacement expressions. they will be replaced by a blank whitespace chracter. characters *will* be off for the same line
48a44d9
to
3aa6c6d
Compare
Merged
This was referenced Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds some support for template strings with variable replacement expressions. this should remove the validation error for EOL. completion and hover should work for all segments of the template literal expression as well
the expressions will be replaced by a blank whitespace character.
characters will be off for the same line, so it won't work everywhere, and if replacing the template string expression still breaks parsing because of how its used, there isn't much else we can do