Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add monaco-graphql special wg minutes #2203

Merged
merged 1 commit into from
Feb 23, 2022
Merged

Add monaco-graphql special wg minutes #2203

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add monaco-graphql special wg minutes 
We can make this into a monthly thing, as we focus on issues that are a bit too low level for graphiql WG, or for requirements beyond the needs of graphiql (such as SDL editing)
  • Loading branch information
@acao
acao authored Feb 23, 2022
commit 8304fe2bb2d7857944e9766ffed31c353ecabef9
32 changes: 32 additions & 0 deletions working-group/agendas/2022-22-02-monaco.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
## Ad-Hoc `monaco-graphql` WG pairing session re: SDL editing

### In Attendance

- [@cshaver](github.com/cshaver)
- [@acao](github.com/acao)


### Agenda

- Review bugs with an SDL editing implementation of `monaco-graphql`
- Determine what RFCs we can present to make this problem easier to solve

### Minutes

we looked at:
- confirmed on the latest vite example, too many workers is triggered by schema changes
- look at how schema is shared with the worker, since this can change often
- e.g. innoDB, cache api

found some bugs:
- (monaco-editor) bg missing on autocomplete box - need to create a bug ticket for them!
- repro'd https://github.com/graphql/graphiql/pull/2171/files
- monaco-react webpack example has some bugs that vite doesn't
- would be cool to get a basic cypress test (get model markers from monaco), visual diff testing
- (monaco?) lots of logs from monarchCommon on parsing directives
- improve webpack example config, so the web workers output name aren't hashed
- devx of running examples from root maybe: `yarn run example:<example name>`

### Recording

https://www.dropbox.com/s/scsdezmvwor1ico/wholeaugustsoptfree%20on%202022-02-22%2020-13.mp4?dl=0