Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revive: add comment explaining reason for disabled linter rules #7634

Merged
merged 1 commit into from
Sep 17, 2024
Merged

revive: add comment explaining reason for disabled linter rules #7634

merged 1 commit into from
Sep 17, 2024

Conversation

purnesh42H
Copy link
Contributor

RELEASE NOTES: None

@purnesh42H purnesh42H added Area: Tooling Includes anything related to Go builds, modules etc and includes Releases & Github Workflows. Type: Meta Github repo, process, etc labels Sep 16, 2024
@purnesh42H purnesh42H added this to the 1.68 Release milestone Sep 16, 2024
@purnesh42H purnesh42H force-pushed the add-comments-for-disabled-revive-rules branch from 8083ea6 to f441be0 Compare September 16, 2024 19:03
@codecov Codecov
Copy link

codecov bot commented Sep 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.88%. Comparing base (3b626a7) to head (4f6b21d).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7634      +/-   ##
==========================================
- Coverage   81.92%   81.88%   -0.04%     
==========================================
  Files         361      361              
  Lines       27816    27816              
==========================================
- Hits        22787    22778       -9     
- Misses       3840     3843       +3     
- Partials     1189     1195       +6

see 16 files with indirect coverage changes

@purnesh42H purnesh42H force-pushed the add-comments-for-disabled-revive-rules branch from f441be0 to 4f6b21d Compare September 17, 2024 06:26
@purnesh42H purnesh42H merged commit 11c44fb into grpc:master Sep 17, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfawley dfawley dfawley approved these changes

Assignees

@purnesh42H purnesh42H

Labels
Area: Tooling Includes anything related to Go builds, modules etc and includes Releases & Github Workflows. Type: Meta Github repo, process, etc
Projects
None yet
Milestone
1.68 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@purnesh42H @dfawley