Skip to content

Add Resource Manager to P2P Host #4815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 19, 2024
Merged

Add Resource Manager to P2P Host #4815

merged 6 commits into from
Dec 19, 2024

Conversation

GheisMohammadi
Copy link
Collaborator

@GheisMohammadi GheisMohammadi commented Dec 12, 2024 •
edited by sophoah
Loading

This PR adds resource manager to p2p configurations. The new configs are as below:

ResourceMgrEnabled   (**FLAG:**  --p2p.resmgr-enabled)     --> default: false
ResourceMgrMemoryLimitBytes (**FLAG:** --p2p.resmgr-memory-limit-bytes)   --> 0: unlimited
ResourceMgrFileDescriptorsLimit (**FLAG:** --p2p.resmgr-file-descriptor-limit)  --> 0: unlimited

config v2.6.5

The resource manager is disabled by default. When enabled, the default configuration allows unlimited resource usage.
The resource manager is enabled by default for bootnode

@GheisMohammadi GheisMohammadi marked this pull request as draft December 12, 2024 14:39
@GheisMohammadi GheisMohammadi force-pushed the feature/p2p_resource_manager branch from bb26882 to 17597d4 Compare December 12, 2024 14:41
@GheisMohammadi GheisMohammadi self-assigned this Dec 12, 2024
@GheisMohammadi GheisMohammadi marked this pull request as ready for review December 13, 2024 07:04
@GheisMohammadi GheisMohammadi added the libp2p Peer to Peer networking label Dec 13, 2024
@sophoah
Copy link
Contributor

sophoah commented Dec 17, 2024

tested on bootnode1 out of 4 and hat confirmed resolving the p2p bootnode issue at boot.

mur-me
mur-me reviewed Dec 17, 2024
View reviewed changes
mur-me
mur-me reviewed Dec 17, 2024
View reviewed changes
@sophoah sophoah merged commit c84173a into dev Dec 19, 2024
4 checks passed
@sophoah sophoah deleted the feature/p2p_resource_manager branch December 19, 2024 10:20
@sophoah sophoah mentioned this pull request Jan 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mur-me mur-me mur-me approved these changes

@Frozen Frozen Frozen approved these changes

+1 more reviewer

@sophoah sophoah sophoah approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@GheisMohammadi GheisMohammadi

Labels
libp2p Peer to Peer networking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GheisMohammadi @sophoah @Frozen @mur-me