Skip to content

Fix: Incorrect permissions in the member object & in commands #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 26, 2023
Merged

Fix: Incorrect permissions in the member object & in commands #340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c4d3f4
Make owner bypass perm check & Fix perms not being updated
Bloxs Feb 5, 2023
3c906a8
Eslint be like
Bloxs Feb 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/commands/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,9 @@ export class CommandClient extends Client implements CommandClientOptions {
const missing: string[] = []

for (const perm of permissions) {
const has = msg.member?.permissions.has(perm)
const has =
msg.guild.ownerID === msg.author.id ||
msg.member?.permissions.has(perm)
if (has !== true) missing.push(perm)
}

Expand Down
25 changes: 23 additions & 2 deletions src/structures/member.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,29 @@ export class Member extends SnowflakeBase {
this.user = user
this.guild = guild
this.roles = new MemberRolesManager(this.client, this.guild.roles, this)
if (perms !== undefined) this.permissions = perms
else this.permissions = new Permissions(Permissions.DEFAULT)
this.permissions = perms ?? new Permissions(Permissions.DEFAULT)
this.roles.array().then((roles) => {
const rolePermissions: string[] = []

for (const role of roles) {
rolePermissions.push(
...role.permissions
.toArray()
.filter((p) => !rolePermissions.includes(p))
)
}

this.permissions.remove(
...this.permissions
.toArray()
.filter((p) => !rolePermissions.includes(p))
)
this.permissions.add(
...rolePermissions.filter(
(p) => this.permissions.toArray().includes(p) === false
)
)
})
}

get displayName(): string {
Expand Down