core: disable spirv validation

hexops · Oct 8, 2024 · a7d5462 · a7d5462
1 parent a791089
commit a7d5462
Showing 1 changed file with 11 additions and 8 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -51,14 +51,17 @@ jobs:
         run: zig build -Dsysgpu test
       - name: test (specific deps only)
         run: zig build -Dcore -Dsysaudio -Dsysgpu test
-      - name: 'sysgpu: validate spirv code generation'
-        run: |
-          wget -qO- https://packages.lunarg.com/lunarg-signing-key-pub.asc | sudo tee /etc/apt/trusted.gpg.d/lunarg.asc
-          sudo wget -qO /etc/apt/sources.list.d/lunarg-vulkan-jammy.list http://packages.lunarg.com/vulkan/lunarg-vulkan-jammy.list
-          sudo apt update
-          sudo apt install vulkan-sdk spirv-tools
-      - name: 'sysgpu: validate spirv output'
-        run: bash ./src/sysgpu/tools/validate_spirv.sh
+      ## TODO: use hexops/spirv-tools for spirv validation instead OR if we are using ZLS finally, just remove this commented block
+      ## The following block throws this error, so it is disabled for now:
+      ## https://github.com/hexops/mach/actions/runs/11223060751/job/31196848244?pr=1279#step:14:79
+      # - name: 'sysgpu: validate spirv code generation'
+      #   run: |
+      #     wget -qO- https://packages.lunarg.com/lunarg-signing-key-pub.asc | sudo tee /etc/apt/trusted.gpg.d/lunarg.asc
+      #     sudo wget -qO /etc/apt/sources.list.d/lunarg-vulkan-jammy.list http://packages.lunarg.com/vulkan/lunarg-vulkan-jammy.list
+      #     sudo apt update
+      #     sudo apt install libyaml-cpp-dev vulkan-sdk spirv-tools
+      # - name: 'sysgpu: validate spirv output'
+      #   run: bash ./src/sysgpu/tools/validate_spirv.sh
   x86_64-windows:
     runs-on: windows-latest
     # We want to run on external PRs, but not on our own internal PRs as they'll be run by the push