This repository has been archived by the owner on Oct 3, 2020. It is now read-only.
Added space for unassigned pods when there are no master nodes #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we should only add this space in case there are no master nodes (too not waste space if there are some). |
|
I've made changes so the unassigned pods will appear to the right of the worker nodes if there are no masters. |
# Conflicts: # .gitattributes
…ps-view into fix-no-masters # Conflicts: # .gitattributes
|
Thanks! I also changed the mock data to have one cluster without master nodes: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In systems where the master nodes are restricted (like AKS), there is nowhere for unassigned pods to be placed in the dashboard. In the screenshot below you can see the unassigned pods are placed over the top of the first node.
This PR adds a small amount of padding that can be used to host unassigned pods when there are no master nodes present.