-
Notifications
You must be signed in to change notification settings - Fork 11
Call download task from TaskMetadataExtract #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
iiab-diagnostics http://sprunge.us/hrfrUF?en 1.Valid Download: https://www.youtube.com/watch?v=AE1aNFeV_2s✅ Run the download task and verify that it logs "No requested files found in the database." ✅ Check that the progress is set to 0 and an error is displayed in Tasks. ✅ |
To allow all videos from a single session to be added in the same bookshelf (when a playlist URL is provided)
Introduce a slow down while ensuring we catch up with progress cycles
It's time. Waiting for his confirmation. |
Test after applying PR 110,111,112 AND 113 |
Thanks @EMG70 for your feedback. Improvements will be added after they are merged. |
🚀 Pull Request Overview:
This pull request refactors the download task to be called from within the media metadata one (TaskMediaMeta). This ensures every single video is downloaded in its own task.
📋 Checklist:
🔗 Related Issue(s):
Issue #104
📌 Testing scenarios:
See Issue #97
cc @EMG70
PS This PR builds upon #109, #110, #111