Ensure fail-safe downloads when an invalid URL was submitted in a previous session #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents failure when xklb-metadata.db is just created.
|
Tested on new Ubuntu 24.04 VM like this:
|
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request Overview:
This PR checks whether column error exists or not using the
PRAGMA table_info(media)statement. This statement retrieves information about the columns in the "media" table. Column "error won't exist if xklb-metadata.db is created by the current run/session. In this case, the first error will be a TypeError and reported as such. If xklb-metadata.db exists prior the run/session, meaningful errors are retrieved from error column instead.NB This PR is a rework of #122, ensuring new valid downloads will not fail when an invalid URL was submitted in a previous session.
📋 Checklist:
🐛 Related issue(s): #114, #120
📌 Testing scenarios:
cc @EMG70