Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed unescaped single-quotes #211

Merged
merged 1 commit into from
Oct 23, 2023
Merged

fixed unescaped single-quotes #211

merged 1 commit into from
Oct 23, 2023

Conversation

paralogismos
Copy link
Contributor

Installing a fresh version of lua-mode on Emacs 29.1 I got several warnings such as:

In lua-find-regexp:
lua-mode.el:994:2: Warning: docstring has wrong usage of unescaped single
    quotes (use \= or different quoting)

It seems that the byte compiler started warning about some quoting mistakes in docstrings starting with Emacs 29, and single-quotes now need to be escaped with \=. Apparently the unescaped single-quotes can be rendered incorrectly.

I escaped the single-quotes, except for some which were paired. I changed those to backquote/single-quote pairs like `foo'; it seems that these pairs are fine.

The only byte-compiler warnings I saw after were for three docstrings wider than 80 characters, and I left those alone.

@immerrr
Copy link
Owner

immerrr commented Oct 23, 2023

Looks good, thanks!

@immerrr immerrr merged commit fb14be9 into immerrr:master Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants