-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Empty Recycle Bin strange behavior #11057
Comments
The deletion is not instant, but gets processed in a background job. If you press the empty bin button only once and then wait a bit, does it still happen? |
Let me check |
Yeah same problem also waiting some times Network tab of chrome dev tools:
With debug log enabled:
Any way to check the bg job to check if is doing is job? |
Is that the only line logged? |
Tested it another time:
|
Can you restart the immich-server container and then post the full startup logs? |
|
Deleting recycle bin is strange. I had to clean 20-30k duplicates multiple times and when everything was in trash and i deleted all at once, it can take some time. i waited, server load goes to zero, but always at the end there are 162 or 1xx photos left in trash. Press delete all again and images are deleted. Have this every time when deleting a lot of images. |
Even if I delete a few photos, they reappear upon refreshing. I had to delete each photo individually from the photo viewer. |
This is actually a pretty interesting bug. The problem is we're updating the isTrashed status while pagination through the results. Basically:
|
Oh, and this also impacts restoring assets as well. I believe if you select all assets and hit "delete 1,xxx" or "restore 1,xxx" that would work fine since it has all the IDs ahead of time. |
The bug
Trying to delete all the photo from the recycle bin but seems to be impossible.
I had deleted some elements that now are in the recycle bin and I have to press multiple times "Empty Recycle Bin" and refresh the page.
The photo comes from my mobile phone with auto backup on.
There is no file from an external library.
Press "Empty Recycle Bin" seems to delete all
Now refresh the page
Press again "Empty Recycle Bin"
Refresh again
Press again "Empty Recycle Bin"
Refresh again
Press again "Empty Recycle Bin"
Refresh again
The OS that Immich Server is running on
Ubuntu 22.04.4 LTS
Version of Immich Server
v1.108.0
Version of Immich Mobile App
v1.108.0 build 148
Platform with the issue
Your docker-compose.yml content
Your .env content
Reproduction steps
1. Go to the trash page 2. Press "Empty Recycle Bin" 3. Confirm 4. Refresh the page
Relevant log output
Checking the chrome dev tools network tab I see the DELETE request:
Request URL: http://example.com:2283/api/assets
Request method: DELETE
Status Code: 204 No Content
Request Payload:
There is nothing in the response tab. Double click on the network line: {"message":"Cannot GET /api/assets","error":"Not Found","statusCode":404,"correlationId":"..."}
Additional information
This problem seems to happend not only with the "Empty Recycle Bin" button.
Select one day from the trash page
Press the "Delete Permanently" button
Refresh the page
and so on
The text was updated successfully, but these errors were encountered: