refactor(mobile): repositories for album service #12701
Conversation
| import 'package:immich_mobile/entities/user.entity.dart'; | ||
|
|
||
| abstract interface class IAssetRepository { | ||
| Future<List<Asset>> getByAlbumWithOwnerUnequal(Album album, User user); |
There was a problem hiding this comment.
This name is a bit unwieldy, maybe just getAlbums({ notOwnedBy}). Also why do you need to get albums not owned by the user? Is that essentially shared with user? Would albumRepo.getSharedWithMe work as well?
There was a problem hiding this comment.
this should actually return the Assets belonging to a specific album but not owned by user x. I've modified the signature; it's now easier to read
|
In the server we try to avoid having services depend on other services. Common code used by two is extracted out to a utility file or class, and then testing only has to inject repository mocks. Do you think we can eventually get to that here as well? |
|
I think we can move in that direction with mobile as well. It will certainly take a few more PRs but it's doable (maybe we need to rename the sync service to a repository :-P) |
|
@fyfrey feel free to merge these refactor PRs after I give an approval. |
This PR adds repositories for the album service to access the local database.
Removes all direct dependencies on Isar within the album service.
Could only add single unit test so far (because it first needs repositories for OpenAPI interaction to test any other methods of the album service)