fix: empty and restore over 1,000 items #12751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zackpollard
reviewed
Sep 17, 2024
e6870d0
to
69473dc
Compare
zackpollard
approved these changes
Sep 18, 2024
|
LGTM |
mertalev
reviewed
Sep 20, 2024
Comment on lines
+185
to
+190
| export enum AssetStatus { | ||
| ACTIVE = 'active', | ||
| TRASHED = 'trashed', | ||
| DELETED = 'deleted', | ||
| } | ||
|
|
There was a problem hiding this comment.
I'm confused. Why do we need this?
There was a problem hiding this comment.
To immediately remove assets from the trash can while they are being deleted in the background.
There was a problem hiding this comment.
Meh, I wouldn't have added a status column just for that. You could have had a websocket event for "deletion in progress" with a spinner or similar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11057
Also correctly reports the trash restore/empty count, which was previously only the number of assets loaded in the UI.