Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(mobile): album api repository for album service #12791

Merged
merged 8 commits into from
Sep 20, 2024
Merged

refactor(mobile): album api repository for album service #12791

merged 8 commits into from
Sep 20, 2024
+748 −220

Conversation

fyfrey
Copy link
Contributor

@fyfrey fyfrey commented Sep 19, 2024 •
edited
Loading

  • This PR adds a new repository to perform action with the Album API.
  • The AlbumApiRepository is used in the AlbumService that no longer depends on OpenAPI! :-)
  • replaces usage of AlbumResponseDto throughout AlbumService and SyncService with Album (needed a few nasty tricks to get there, sadly)
  • finally add some unit tests for AlbumService methods (now that API access can me easily mocked)
  • new linting checking openapi usage (limit to all files still using it as of this PR)

@fyfrey fyfrey requested a review from jrasm91 September 19, 2024 14:50
@fyfrey fyfrey enabled auto-merge (squash) September 20, 2024 13:32
@fyfrey fyfrey merged commit 3868736 into main Sep 20, 2024
35 checks passed
@fyfrey fyfrey deleted the refactor/mobile-album-api-repository branch September 20, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrasm91 jrasm91 jrasm91 approved these changes

Assignees
No one assigned
Labels
changelog:skip 📱mobile
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fyfrey @jrasm91