New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(web): remove stray dateTimeOriginal reference #12796

Merged

jrasm91 merged 1 commit into main from chore/remove-stray-reference

Sep 19, 2024

Contributor

jrasm91 commented Sep 19, 2024

Basically:

asset.fileCreatedAt should only ever be used for sorting within a bucket
dateTimeOriginal should only be used for displaying in the detail view when there is a timezone, and we can probably deduce this from localDateTime itself in the future
localDateTime should be used for everything else


          chore(web): remove stray dateTimeOriginal reference

31226d8

jrasm91 added the changelog:skip label

github-actions bot added the 🖥️web label

bo0tzz approved these changes

View reviewed changes

Member

bo0tzz left a comment

We should probably document these distinctions somewhere

jrasm91 merged commit cfc575d into main

36 checks passed

jrasm91 deleted the chore/remove-stray-reference branch

September 19, 2024 21:06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:skip 🖥️web