fix: rework file handling so we always explicitly create, overwrite or both #12812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieldietzler
approved these changes
Sep 20, 2024
13ab2a9
to
d2b3066
Compare
jrasm91
approved these changes
Sep 20, 2024
alextran1502
approved these changes
Sep 20, 2024
…r create/overwrite
d2b3066
to
5c1fb4b
Compare
Done 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to nodejs/node#41093 we are unable to open hidden files with the 'w' flag on windows and some samba shares. This got me thinking, and realistically we should never actually need to open files with the w flag anyway. In all contexts within immich we know if we are opening a file for creating or overwriting, so we can explicitly use those actions in those contexts. This means we now have more protections when creating file, as if somehow a file exists on the filesystem, but we didn't expect it to, the code will error rather than overwrite it.