feat(server): wait five minutes before sending email on new album item #12223
Conversation
b2edd02
to
da5139a
Compare
a4747cb
to
d1b26dc
Compare
6a50955
to
d79fb91
Compare
d79fb91
to
716df83
Compare
|
We talked about different approaches for notifications, but came to the conclusion that this approach is fine for now until we have a more detailed plan on how notifications should be scheduled. |
716df83
to
37cb0df
Compare
|
@mertalev @alextran1502 I've resolved conflicts, this should be ready for review now |
|
Just a thought: i'd love to see this either configurable (which would be a lot more work I assume), or have 60 seconds bumped up to something way higher, like 15 minutes or something. Like, why not? |
Let's get this pull request through first. I just went on vacation with some friends and they always complain when someone uploads one or more pictures. I had to temporarily completely deactivate the email notification function until further notice so that your inbox wouldn't be flooded. |
37cb0df
to
30e52c3
Compare
|
Yeah I picked 60 seconds since it takes a quarter of that time to upload an image one-by-one to my VPS running Immich. If I recall correctly. a workaround to prevent the notification flood is to upload all the images to your user, then navigate to the album and bulk add them there (plus at top right on web) so they aren't added one-by-one. |
30e52c3
to
34ada94
Compare
|
I think 60s is a little too short considering videos and slower connections. 300s would be nicer imo |
34ada94
to
f32a12f
Compare
9c4293e
to
0207ab3
Compare
0207ab3
to
7386bb7
Compare
fcaab70
to
f7391b9
Compare
Album update jobs will now wait five minutes to send. If a new image is added while that job is pending, the old job will be cancelled, and a new one will be enqueued for a minute. This is to prevent a flood of notifications by dragging in images directly to the album, which adds them to the album one at a time. Album updates now include a list of users to email, which is generally everybody except the updater. If somebody else updates the album within that minute, both people will get an album update email in a minute, as they both added images and the other should be notified.
f7391b9
to
5a770af
Compare
immich-app#12223) Album update jobs will now wait five minutes to send. If a new image is added while that job is pending, the old job will be cancelled, and a new one will be enqueued for a minute. This is to prevent a flood of notifications by dragging in images directly to the album, which adds them to the album one at a time. Album updates now include a list of users to email, which is generally everybody except the updater. If somebody else updates the album within that minute, both people will get an album update email in a minute, as they both added images and the other should be notified.
Album update jobs will now wait five minutes to send. If a new image is added while that job is pending, the old job will be cancelled, and a new one will be enqueued for a minute.
This is to prevent a flood of notifications by dragging in images directly to the album, which adds them to the album one at a time.
Album updates now include a list of users to email, which is generally everybody except the updater. If somebody else updates the album within that minute, both people will get an album update email in a minute, as they both added images and the other should be notified.