-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add QR code for shared link #13128
base: main
Are you sure you want to change the base?
Conversation
this time i am using svelte-qrcode to generate the QR code and its being added as module, not as library. Hope that's better now |
...src/lib/components/shared-components/create-share-link-modal/create-shared-link-modal.svelte
Outdated
Show resolved
Hide resolved
...src/lib/components/shared-components/create-share-link-modal/create-shared-link-modal.svelte
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I'm not sure if we want a fixed width for the QR code though
Also, please fix the typescript issues. |
Hello, thank you for the PR. What is the use case of this PR? How are you planning to share the QR code? |
hi @alextran1502 , my use case is as follows - i shoot people on the street and when i am done i create album and share that code over phone to the person who will later have photos there for download. I dont share any phone numbers or contact details to send link later. I understand that this is a change in UI and not everyone would like to have it always on - if you want i will try to add switch to User settings (feature toggle) and by default QR code would be disabled. Second option would be to click on "generate QR" button once link is created. This way it would be less "pushy" feature |
I think having a button to generate the QR code upon request is a good idea. Also it would be useful to be able to share the QR code as image would be beneficial to send the code to different users, or to print it |
Any progress on this PR? |
I definitely like the idea of generating a QR code for stuff like this, but I think the user experience could be better. I am wondering if after generating the link we have a button that when you click it, it opens a full screen modal with the QR code in it. It could have some buttons in the footer to download it, etc. Is something you want to take a look at? Otherwise I can push some changes to this branch. |
Hey, I think this is getting closer, however I think I would still like to see a small change here. This QR code feature is good, but I think the button is still far to prominent for the amount of people that will likely use it. I'd personally like to see this as a small QR code symbol within or next to the link box itself. Similar to the copy button. This seems much more reusable in other areas if we have links, and also much smaller and out of the way. |
Simple patch to add QR code to the dialog where link for album sharing is generated