Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add QR code for shared link #13128

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

feat: add QR code for shared link #13128

wants to merge 19 commits into from

Conversation

jnav
Copy link

@jnav jnav commented Oct 2, 2024

Simple patch to add QR code to the dialog where link for album sharing is generated

2024-10-02-immich_QR

web/src/lib/utils/qrcode.js Outdated Show resolved Hide resolved
@jnav
Copy link
Author

jnav commented Oct 3, 2024

this time i am using svelte-qrcode to generate the QR code and its being added as module, not as library. Hope that's better now

@danieldietzler danieldietzler changed the title added QR Code generation image once shared link is generated feat: add QR code for shared link Oct 3, 2024
Copy link
Member

@danieldietzler danieldietzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'm not sure if we want a fixed width for the QR code though

@danieldietzler
Copy link
Member

Also, please fix the typescript issues.

@alextran1502
Copy link
Contributor

Hello, thank you for the PR. What is the use case of this PR? How are you planning to share the QR code?

@jnav
Copy link
Author

jnav commented Oct 8, 2024

hi @alextran1502 , my use case is as follows - i shoot people on the street and when i am done i create album and share that code over phone to the person who will later have photos there for download. I dont share any phone numbers or contact details to send link later. I understand that this is a change in UI and not everyone would like to have it always on - if you want i will try to add switch to User settings (feature toggle) and by default QR code would be disabled. Second option would be to click on "generate QR" button once link is created. This way it would be less "pushy" feature

@alextran1502
Copy link
Contributor

I think having a button to generate the QR code upon request is a good idea. Also it would be useful to be able to share the QR code as image would be beneficial to send the code to different users, or to print it

@CrushedAsian255
Copy link
Contributor

Any progress on this PR?

@jrasm91
Copy link
Contributor

jrasm91 commented Oct 24, 2024

I definitely like the idea of generating a QR code for stuff like this, but I think the user experience could be better. I am wondering if after generating the link we have a button that when you click it, it opens a full screen modal with the QR code in it. It could have some buttons in the footer to download it, etc.

Is something you want to take a look at? Otherwise I can push some changes to this branch.

@jnav
Copy link
Author

jnav commented Oct 25, 2024

added button to generate QR code, hope its less intrusive solution. I wanted to scroll to the bottom of QR code after its being generated, but i failed %-|

thank you for your comments/reviews

2024-10-25-QR-button

@zackpollard
Copy link
Contributor

Hey, I think this is getting closer, however I think I would still like to see a small change here. This QR code feature is good, but I think the button is still far to prominent for the amount of people that will likely use it. I'd personally like to see this as a small QR code symbol within or next to the link box itself. Similar to the copy button. This seems much more reusable in other areas if we have links, and also much smaller and out of the way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants