Map Feature #2292
Closed
Map Feature #2292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
bo0tzz
requested changes
Apr 19, 2023
| @@ -17,7 +17,7 @@ | |||
| "name": "assetId", | |||
| "required": false, | |||
| "in": "query", | |||
| "description": "Only returns albums that contain the asset\nIgnores the shared parameter\nundefined: get all albums", | |||
| "description": "Only returns albums that contain the asset\rIgnores the shared parameter\rundefined: get all albums", | |||
There was a problem hiding this comment.
There's some odd whitespace changes in this PR, please remove those.
There was a problem hiding this comment.
FYI, I believe that EPP said on discord that he wouldn't be able to work on this further
Comment on lines
+38
to
+40
| .tileLayer('https://{s}.tile.openstreetmap.org/{z}/{x}/{y}.png', { | ||
| attribution: '© <a href="https://www.openstreetmap.org/copyright">OpenStreetMap</a>' | ||
| }) |
There was a problem hiding this comment.
I believe this approach is not in compliance with OSM's tile usage policy (https://operations.osmfoundation.org/policies/tiles/). Can we change things so that it is, or do we need to evaluate using another tileserver?
Comment on lines
+152
to
+157
| <link | ||
| rel="stylesheet" | ||
| href="https://unpkg.com/leaflet@1.6.0/dist/leaflet.css" | ||
| integrity="sha512-xwE/Az9zrjBIphAcBb3F6JVqxf46+CDLwfLMHloNu6KEQCAWi6HcDUbeOfBIptF7tcCzusKFjFw2yuvEpDL9wQ==" | ||
| crossorigin="" | ||
| /> |
There was a problem hiding this comment.
Please install this as an NPM dependency instead of using a CDN.
7 tasks
|
Superseded by #2355 |
|
Thanks for kick starting this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A map view to display where photos were taken