-
Notifications
You must be signed in to change notification settings - Fork 59
New elvis_text_style
rule: no_redundant_blank_lines
#381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
elbrujohalcon
merged 10 commits into
inaka:main
from
bormilan:feature/redundant-blank-lines
Feb 3, 2025
Merged
New elvis_text_style
rule: no_redundant_blank_lines
#381
elbrujohalcon
merged 10 commits into
inaka:main
from
bormilan:feature/redundant-blank-lines
Feb 3, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
097501e
to
b7116b0
Compare
elbrujohalcon
requested changes
Jan 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice PR, @bormilan … a few extra tweaks.
Co-authored-by: Brujo Benavides <elbrujohalcon@gmail.com>
Co-authored-by: Brujo Benavides <elbrujohalcon@gmail.com>
elbrujohalcon
requested changes
Feb 1, 2025
elbrujohalcon
approved these changes
Feb 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, @bormilan
1 task
elvis_text_style
rule: no_redundant_blank_lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a function that counts blank lines and filters out those that reach the given maximum value.
Closes #296.