Skip to content

Restore/deprecate output_file_name and add output_file_path #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 5, 2025
Merged

Restore/deprecate output_file_name and add output_file_path #477

merged 1 commit into from
Sep 5, 2025

Conversation

majosm
Copy link
Collaborator

@majosm majosm commented Sep 3, 2025 •
edited
Loading

Adds output_file_name back to generate_gmsh (and deprecates it). Adds output_file_path that can point outside of the current working directory.

Draft because:

@majosm majosm mentioned this pull request Sep 4, 2025
Merged
@majosm majosm marked this pull request as ready for review September 5, 2025 16:03
@majosm majosm marked this pull request as draft September 5, 2025 16:04
@majosm majosm force-pushed the gmsh-output-file-path branch from 850e979 to 3c99c41 Compare September 5, 2025 16:04
@majosm majosm marked this pull request as ready for review September 5, 2025 17:21
@majosm majosm requested a review from inducer September 5, 2025 17:21
@inducer inducer merged commit 09d3270 into inducer:main Sep 5, 2025
12 checks passed
@majosm majosm mentioned this pull request Sep 24, 2025
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inducer inducer Awaiting requested review from inducer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@majosm @inducer