Skip to content

Wrap the AbstractBMP type (implemented using variant) in the BMP index. #2620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 22, 2025
Merged

Wrap the AbstractBMP type (implemented using variant) in the BMP index. #2620

merged 2 commits into from
May 22, 2025
+745 −7

Conversation

19-hanhan
Copy link
Contributor

What problem does this PR solve?

  1. Replace AbstractBMP (implemented as a variant) with BMPHandler (implemented as a class).
  2. Wrap AbstractBMP's operations into BMPHandler using member functions.

Type of change

  • Refactoring
  • Performance Improvement

@19-hanhan 19-hanhan added the ci PR can be test label May 21, 2025
19-hanhan added 2 commits May 22, 2025 10:57
@19-hanhan
Wrap the AbstractBMP type (implemented using variant) in the BMP index.
9d8dcea 
Signed-off-by: Long <2262328655@qq.com>
@19-hanhan
bugfix: resolve SearchIndex logic error
a349050 
Signed-off-by: Long <2262328655@qq.com>
@JinHai-CN JinHai-CN merged commit ddd7eea into infiniflow:main May 22, 2025
3 checks passed
@19-hanhan 19-hanhan deleted the bmpdev branch May 26, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci PR can be test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@19-hanhan @JinHai-CN