Bunch of TS errors from reactotron-core-client in a fresh project #1430
Comments
|
The reason is that react-native is using the untranspiled typescript files from A workaround from user side is to use the transpiled js & .d.ts files, that way ts can ignore those error: (this is for RN73, if you are on older version you have to change the other "react-native" entry) |
|
Jest is failing with the tests and i believe its due to the same issue. The suggestion of @WookieFPV haven't solved it for me: |
|
I have the same problem and the solutions above is not working... Any update? |
|
This PR should solve these problems: |
|
Well, once you merge it, i will let you know :) |
|
Any updates? |
|
are there any updates on this one? |
|
just had this problem happen today as I tried reactotron for the forst time, uninstalling for now. |
|
any updates? |
|
As a temp solution I changed from import to require and TS stops checking the package: before import Reactotron, { networking } from 'reactotron-react-native'
import { reactotronRedux } from 'reactotron-redux'after const { reactotronRedux } = require('reactotron-redux')
const Reactotron = require('reactotron-react-native').default
const { networking } = require('reactotron-react-native') |
it helped, thanks! |
In my case this unfortunately doesn't work (at least in a Jest test): |
|
Same error using the last reactotron-react-native version (5.1.9). Using require instead of import works. |
|
@twerth @jamonholmgren @markrickert This issue has been open for ten months and people still have to use a workaround. Can y'all have someone over at InfiniteRed take a look at this issue? Duplicated by #1483, #1420 and a direct callout in the React Native main repo here. @crutchcorn opened PR #1466 to fix it. I would fix your docs CI build if I knew what the issue was. @Bardiamist opened issue #1420 which has a patch file that fixes it. The react-native issue tells you the root cause. There is also a suboptimal workaround the community is using. With Flipper gone, the community is relying on Reactotron. The developer experience should work with the officially supported react-native typescript configuration. Being used by the community doesn't obligate you to implement everything we want or deeply investigate every issue. There is source code. We have a debugger. We can fork your code or implement pull requests if we really want to. What we can't do is merge fixes to the basic package configuration into the main package. That's something only your team can do. That is your responsibility. Multiple people have fixes for this issue. This seems like an easy win for community trust. Please help us by getting a new version out this week with the fixes in place. Thank you |
## Please verify the following: - [x] `yarn build-and-test:local` passes - [x] I have added tests for any new features, if relevant - [x] `README.md` (or relevant documentation) has been updated with your changes ## Describe your PR This PR enables strict mode for the `reactotron-core-client` codebase to fix issues documented here: #1430
|
Sorry this took so long, we have merged @crutchcorn PR and now those changes are released in reactotron-core-client@2.9.5! |
|
@joshuayoes when can we get the newest react-native package, which uses the latest core-client package? |
|
Hey folks, we ran into a CI issue on Ignite, which means we might be breaking your apps too, so we're going to look at potentially re-releasing as a breaking 3.0.0 change for reactotron-core-client. Error details here |
If you're using yarn, you can set the resolution field to use that version of core-client. |
tsconfig:
{ "extends": "@react-native/typescript-config/tsconfig.json", "compilerOptions": { "baseUrl": "src", "rootDir": ".", "strict": true, "strictBindCallApply": true, "strictFunctionTypes": true, "strictNullChecks": true, "strictPropertyInitialization": true, "pretty": true, "allowImportingTsExtensions": false, "allowJs": false, "noImplicitAny": true, "noImplicitOverride": true, "noImplicitThis": true, "noUnusedLocals": true, "noUnusedParameters": true, "noImplicitReturns": true, "noFallthroughCasesInSwitch": true, "noUncheckedIndexedAccess": true, "useUnknownInCatchVariables": true, "noEmit": true, "module": "ES2022", "typeRoots": ["./node_modules/@types", "./src/@types"], }, "exclude": [ "node_modules/**/*", "babel.config.js", "metro.config.js", "jest.config.js", "eslint.config.js", "config/**/*" ] }Include location:
tsc output:
The text was updated successfully, but these errors were encountered: