Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added TLS & credentials configuration for NATS_consumer input plugin #6195

Merged
merged 2 commits into from
Aug 2, 2019
Merged

Conversation

mmelnyk
Copy link
Contributor

@mmelnyk mmelnyk commented Aug 2, 2019

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

Basic changes to add missing TLS & credentials options for NATS. Mutual TLS is supported too.

@danielnelson danielnelson added this to the 1.12.0 milestone Aug 2, 2019
@danielnelson danielnelson added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Aug 2, 2019
@danielnelson danielnelson merged commit 0732b41 into influxdata:master Aug 2, 2019
@danielnelson
Copy link
Contributor

I've got thinking about this a bit more and realize that we still need the secure option, otherwise it isn't possible to connect with a default tls.Config. Normally it would be controlled by the URL in a HTTP input (http vs https), or by using a enable_tls option, but since we already have secure I added it back in ffe9494.

@mmelnyk
Copy link
Contributor Author

mmelnyk commented Aug 2, 2019

There are some inconsistencies in options for other plugins - e.g. nats output (btw, readme for this plugin needs updating) does not have "secure" option, but usually used in a pair with nats_consumer.

@danielnelson
Copy link
Contributor

I added the same option to the output too now, technically this is a breaking change as you now must set the secure option to use TLS, it's not enough to just use non default settings.

When it comes to plugin inconsistency, yeah it's quite difficult to keep up, especially considering the number of plugins these days. Definitely relying on the community to open PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants