-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tcp/udp check connection input plugin #650
Conversation
cbff449
to
72b160f
Compare
@sparrc Thanks ! I fixed the sample config ;) |
could you write a README in the format of https://github.com/influxdata/telegraf/blob/master/plugins/inputs/EXAMPLE_README.md? |
since we can specify multiple
|
af1a478
to
27d22e1
Compare
27d22e1
to
b2c20fe
Compare
@sparrc Done ! |
Awesome!! A good way to decrease the latency.. 👍 Thanks |
This looks good @titilambert, the only problem I have is that I feel like the name But, I'm also having trouble coming up with a good name, maybe just |
@sparrc I had the same feeling when I choose the name ... |
I like I'm leaning away from |
@sparrc let's go for |
OK, but someone has already tried to do that: #665 I rejected the PR because it seems that the kubernetes client library is very tied up with their entire repo, and adding it requires adding 10-12 huge dependencies to Telegraf that almost doubled the binary size. Although there's also the option of requiring kubernetes-cli or some external executable as a dependency of the plugin |
@sparrc I do not use kubernetes client lib :) |
b2c20fe
to
f0362e5
Compare
@sparrc changes done ! |
f0362e5
to
160a2d0
Compare
160a2d0
to
c7c689d
Compare
great, thanks for another contribution @titilambert |
@titilambert I sent you an email for some swag ~2 weeks ago, did you receive it? |
@sparrc no I didn't anything. Could you PM me on twitter ? |
@titilambert sure, will do |
Rebased PR of #476