feat(nsq_consumer): Add input plugin to consume metrics from an nsqd topic #1369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a5cb014
to
6162030
Compare
| } | ||
|
|
||
| // SetParser takes the data_format from the config and finds the right parser for that format | ||
| func (nsqConsumer *NSQConsumer) SetParser(parser parsers.Parser) { |
There was a problem hiding this comment.
it's better go style to give this a shorter name internally, like
func (n *NSQConsumer) SetParser(parser parsers.Parser)
df314bf
to
911f0cc
Compare
| } | ||
|
|
||
| var sampleConfig = ` | ||
| ## An array of NSQD HTTP API endpoints |
There was a problem hiding this comment.
it's not an array, just a string. Should it be an array?
|
this will close #1347 |
|
thanks @jchauncey |
chebrolus
pushed a commit
to chebrolus/telegraf
that referenced
this pull request
Jun 24, 2016
to consume metrics from an nsqd topic closes influxdata#1347 closes influxdata#1369
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This plugin allows a user to configure telegraf to pull metric data from an NSQD instance. The data must be in the line protocol format.