Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exporting Ipmi.Path to be set by config. #2498

Merged
merged 3 commits into from
Mar 8, 2017
Merged

Exporting Ipmi.Path to be set by config. #2498

merged 3 commits into from
Mar 8, 2017

Conversation

Robpol86
Copy link
Contributor

@Robpol86 Robpol86 commented Mar 7, 2017 •
edited
Loading

Currently "path" is not exported, giving this error when users try to
override the variable via telegraf.conf as per the sample config:

field corresponding to path' is not defined in *ipmi_sensor.Ipmi'

Exporting the variable solves the problem.

Config:

[[inputs.ipmi_sensor]]
  path = "/usr/local/bin/ipmitool_sdr_f"

Before:

$ sudo telegraf -test
2017/03/06 17:09:12 I! Using config file: /etc/telegraf/telegraf.conf
2017/03/06 17:09:12 E! Error parsing /etc/telegraf/telegraf.conf, line 50: field corresponding to `path' is not defined in `*ipmi_sensor.Ipmi'

After:

$ sudo telegraf -test
2017/03/06 17:17:15 I! Using config file: /etc/telegraf/telegraf.conf
[...]
* Plugin: inputs.ipmi_sensor, Collection 1
> ipmi_sensor,unit=degrees_f,host=filesrv.rob86.net,name=cpu_temp status=1i,value=102.2 1488849436000000000
> ipmi_sensor,name=system_temp,unit=degrees_f,host=filesrv.rob86.net value=98.6,status=1i 1488849436000000000
[...]

Required for all PRs:

  • CHANGELOG.md updated (we recommend not updating this until the PR has been approved by a maintainer)
  • Sign CLA (if not already signed)
  • README.md updated (if adding a new plugin)

@Robpol86
Exporting Ipmi.Path to be set by config.
6a3aa55 
Currently "path" is not exported, giving this error when users try to
override the variable via telegraf.conf as per the sample config:

`field corresponding to `path' is not defined in `*ipmi_sensor.Ipmi'`

Exporting the variable solves the problem.
Robpol86 added a commit to Robpol86/influxdb that referenced this pull request Mar 7, 2017
@Robpol86
Removing docker input, using deg F for IPMI.
cacf97a 
Try as I might I couldn't find a way to get ipmitool to use Fahrenheit
instead of Celsius. I looked in the ipmitool source (which has "degrees
F" but no option to force it), in the ipmi0 kernel module source, and in
my BIOS settings. Nothing.

The solution is to write a wrapper AWK program that does the conversion
for Telegraf.

Won't work until (hopefully)
influxdata/telegraf#2498 is merged.

Not collecting Docker metrics since it requires adding Telegraf to the
"docker" group to give it access to the Docker unix socket. I didn't
really like that from a security perspective. Better to just give up on
that.
@sparrc sparrc added this to the 1.3.0 milestone Mar 7, 2017
@sparrc
Copy link
Contributor

sparrc commented Mar 7, 2017

thanks @Robpol86, can you update the changelog?

@Robpol86
Copy link
Contributor Author

Robpol86 commented Mar 7, 2017

Done!

@Robpol86
Copy link
Contributor Author

Robpol86 commented Mar 7, 2017

Looks like unrelated tests for inputs/socket_listener failed.

@sparrc sparrc merged commit 56aa89e into influxdata:master Mar 8, 2017
ssorathia pushed a commit to ssorathia/telegraf that referenced this pull request Mar 25, 2017
@Robpol86
Exporting Ipmi.Path to be set by config. (influxdata#2498)
19d0c0c 
* Exporting Ipmi.Path to be set by config.

Currently "path" is not exported, giving this error when users try to
override the variable via telegraf.conf as per the sample config:

`field corresponding to `path' is not defined in `*ipmi_sensor.Ipmi'`

Exporting the variable solves the problem.

* Updating changelog.
calerogers pushed a commit to calerogers/telegraf that referenced this pull request Apr 5, 2017
@Robpol86 @calerogers
Exporting Ipmi.Path to be set by config. (influxdata#2498)
9855e9f 
* Exporting Ipmi.Path to be set by config.

Currently "path" is not exported, giving this error when users try to
override the variable via telegraf.conf as per the sample config:

`field corresponding to `path' is not defined in `*ipmi_sensor.Ipmi'`

Exporting the variable solves the problem.

* Updating changelog.
vlamug pushed a commit to vlamug/telegraf that referenced this pull request May 30, 2017
@Robpol86
Exporting Ipmi.Path to be set by config. (influxdata#2498)
ccc54dd 
* Exporting Ipmi.Path to be set by config.

Currently "path" is not exported, giving this error when users try to
override the variable via telegraf.conf as per the sample config:

`field corresponding to `path' is not defined in `*ipmi_sensor.Ipmi'`

Exporting the variable solves the problem.

* Updating changelog.
maxunt pushed a commit that referenced this pull request Jun 26, 2018
@Robpol86 @sparrc
Exporting Ipmi.Path to be set by config. (#2498)
68b10d7 
* Exporting Ipmi.Path to be set by config.

Currently "path" is not exported, giving this error when users try to
override the variable via telegraf.conf as per the sample config:

`field corresponding to `path' is not defined in `*ipmi_sensor.Ipmi'`

Exporting the variable solves the problem.

* Updating changelog.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Robpol86 @sparrc