Add Kafka output plugin topic_suffix option #3196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cs, based on the metric name or tags
37ad17e
to
6bbcfd8
Compare
6bbcfd8
to
96c6bdf
Compare
danielnelson
reviewed
Sep 5, 2017
plugins/outputs/kafka/kafka.go
Outdated
| "": TOPIC_SUFFIX_METHOD_EMPTY, | ||
| "measurement": TOPIC_SUFFIX_METHOD_MEASUREMENT, | ||
| "tag": TOPIC_SUFFIX_METHOD_TAG, | ||
| "tags": TOPIC_SUFFIX_METHOD_TAGS, | ||
| } |
There was a problem hiding this comment.
I would remove the map/enums, they don't really buy us anything from a type safety point of view. You could just have a list of valid strings for validating the config file.
There was a problem hiding this comment.
You're probably right about having separator between topic and topic_suffix, I think that follows the principle of least astonishment, good catch.
Renamed key_separator to just separator also.
I'm not sure about maps/enums though, because they kinda make the code less error-prone, it's easier to make a typo in a string than in a constant name. We have testcases covering that though. (And I'm not familiar with commonly accepted practices in Go).
Pushed! Any other thoughts?
Add test for ValidateTopicSuffixMethod Remove k.Connect() from topic suffixes test
Modify existing testcases accordingly Add more testcases for topic names Modify README.md accordingly
maxunt
pushed a commit
that referenced
this pull request
Jun 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to the Kafka output plugin to send data to different topics, based on the metric name or tags
Required for all PRs:
This addresses #3177