Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: exportable md animations for modal #28464

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

reslear
Copy link

@reslear reslear commented Nov 3, 2023

It is convenient from the point of view when ios style need md style animation (https://ionicframework.com/docs/api/modal#enteranimation) that would not copy the code in the application and always use the latest changes.

exportable mdEnterModalAnimation and mdLeaveModalAnimation

closes: #28499

@github-actions github-actions bot added the package: core @ionic/core package label Nov 3, 2023
@liamdebeasi
Copy link
Contributor

Hey there, could you please create an issue for this? We'd like to understand the use case for this feature before we expose this API. Thanks!

@DwieDima
Copy link
Contributor

DwieDima commented Nov 9, 2023

Hey there, could you please create an issue for this? We'd like to understand the use case for this feature before we expose this API. Thanks!

I think there is already an open issue which address this PR: #24964 (#25243).
It would be great if we could extend this PR to also export ios enter/leave animation as well.

@reslear
Copy link
Author

reslear commented Nov 9, 2023

@liamdebeasi @DwieDima I suggested a more interesting solution in the form of presets see 2 #28499

@reslear reslear requested a review from a team as a code owner January 24, 2024 17:55
@reslear reslear requested review from mapsandapps and removed request for a team January 24, 2024 17:55
@mapsandapps mapsandapps removed their request for review February 1, 2024 20:31
@brandyscarney brandyscarney requested review from a team and BenOsodrac and removed request for a team July 24, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: modal animations regardless of the platform
3 participants