Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom env variables #16701

Draft
wants to merge 29 commits into
base: main
Choose a base branch
from
Draft

Custom env variables #16701

wants to merge 29 commits into from

Conversation

AnastasiaSliusar
Copy link
Contributor

References

Code changes

This PR includes functionality of setuping custom env variables

User-facing changes

  • Kernel select dialog was changed. Now there is opportunity to add custom env variables for a kernel that has not be run yet
  • A user can call context menu on Launcher by clicking on a kernel icon and then setup custom env variables for a kernel
    dialog_kernel_select
    dialog_custom_env_laucher

How to use

Should be use together with https://github.com/AnastasiaSliusar/jupyter_server/tree/custom-env-variables

AnastasiaSliusar and others added 24 commits July 10, 2024 14:37
@AnastasiaSliusar
Add custom env form
be85760
@AnastasiaSliusar
Add link from jupyterlab to jupyterserver for passing custom env vari…
f57183e 
…ables
@AnastasiaSliusar
Update the dialog
3226375
@AnastasiaSliusar
Fix a dialog
775cd68
@AnastasiaSliusar
Update a dialog, add css styles, saving user selection into kernelpre…
9a5339c 
…ferences
@AnastasiaSliusar
Add context menu on Laucher
3b070bf
@AnastasiaSliusar
Merge branch 'jupyterlab:main' into custom-env-variables
de1702e
@github-actions
Automatic application of license header
91fc3a0
@AnastasiaSliusar
Fix context menu on each kernel icon on Launcher
00009c7
@AnastasiaSliusar
Merge branch 'custom-env-variables' of https://github.com/AnastasiaSl…
802924b 
…iusar/jupyterlab into custom-env-variables
@AnastasiaSliusar
Fixing context menu on Launcher
e8c6a88
@AnastasiaSliusar
Fix running a kernel with custom env variables
d63760d
@AnastasiaSliusar
Resolving merge conflicts
b21f63c
@AnastasiaSliusar
Fix a kernel selection dialog
2e88b88
@AnastasiaSliusar
Fix showing checkbox
774dabd
@AnastasiaSliusar
Add support of calling a dialog for custom env variables for console …
feb48de 
…from Launcher
@AnastasiaSliusar
Format code
d9f7ec6
@AnastasiaSliusar
Fix condition of showing a part of dialog for setuping custom env var…
55e31e5 
…iables
@AnastasiaSliusar
Change name of the flag
765a2c4
@AnastasiaSliusar
Add tests
7b18f44
@AnastasiaSliusar
Fix lint and a test
651732d
@AnastasiaSliusar
Resolve conflicts
56c53b6
@AnastasiaSliusar
Fix tests
d959874
@AnastasiaSliusar
Fix tests and eslint
ed2fed8
@jupyterlab-probot jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@github-actions github-actions bot added pkg:apputils pkg:ui-components tag:CSS For general CSS related issues and pecadilloes Design System CSS labels Aug 20, 2024
@AnastasiaSliusar
Copy link
Contributor Author

please update galata snapshots

@AnastasiaSliusar
Copy link
Contributor Author

please update documentation snapshots

@AnastasiaSliusar
Copy link
Contributor Author

please update snapshots

github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 29, 2024
View reviewed changes
packages/notebook-extension/src/index.ts
@@ -2021,6 +2130,18 @@
onSpecsChanged();
services.kernelspecs.specsChanged.connect(onSpecsChanged);
});

const acceptKernelEnvVar =

Check notice

Code scanning / CodeQL

Unused variable, import, function or class

Unused variable acceptKernelEnvVar.
@krassowski krassowski mentioned this pull request Sep 10, 2024
Open
@krassowski
Copy link
Member

Related to jupyter/enhancement-proposals#87 ?

@AnastasiaSliusar
Copy link
Contributor Author

Related to jupyter/enhancement-proposals#87 ?

Dear @krassowski no, this feature is independent. It also touches the topic of running a kernel with some customization. But the difference is that a user can setup custom env variables for a kernel and run it without changes kernel spec files. And jupyter/enhancement-proposals#87 is about allowing to add changes to kernel spec files and then use them when a kernel is run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@AnastasiaSliusar AnastasiaSliusar

Labels
Design System CSS feature pkg:apputils pkg:console pkg:docregistry pkg:notebook pkg:services pkg:ui-components tag:CSS For general CSS related issues and pecadilloes tag:Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AnastasiaSliusar @krassowski @afshin