-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Underscore visibility issue in filenames with 'Ubuntu' font #16824
base: 4.2.x
Are you sure you want to change the base?
Underscore visibility issue in filenames with 'Ubuntu' font #16824
Conversation
Thanks for making a pull request to jupyterlab! |
@JasonWeill |
@Darshan808 I can ask about this at our next regular meeting. Thanks for opening this! |
I see no perceptible difference with this change, compared with 4.2.5, on macOS and Firefox. |
@JasonWeill |
|
@Darshan808 Jupyter projects are not part of Hacktoberfest this year, but we still welcome your contributions. Thanks again! |
I tried to reproduce the error using This appears to be a niche issue that is not originating from Jupyter Lab but a specific version of Ubuntu, and may be automatically handled in new releases of Jupyter Lab. I would recommend leaving it untouched for now, given that changing the line height affects the display on all systems that are unaffected, which is mostly all. This is already suggested here: #16820 (comment) |
I was able to reproduce the original issue on the latest Ubuntu. I do not recall what browser it was with and if only certain zoom sizes were affected. I recall it only started in the latest Ubuntu release so Mint may not be affected yet |
This is not JupyterLab specific though see for example microsoft/vscode#227583 I added more context in #16820 (comment) |
@Darshan808 it looks like this PR was opened against 4.2.x branch rather than master. Can you change the target branch? |
|
@Darshan808 @krassowski Issue #16820 was noted as occurring only in 4.2.x and not in the 4.3.0 beta, so I think the merge into the |
Oh, I overlooked that. Yes, the PR was intended to be created in the 4.2.x branch. |
References
#16820
Problem:
When using the 'Ubuntu' font on the default 100% zoom level in JupyterLab, underscores in filenames were hidden. This issue was observed in the directory listing where filenames with underscores were not fully visible.
Solution:
I explored two solutions to resolve this:
.jp-Dirlisting-itemtext
element..jp-Dirlisting-itemtext
class.I chose to adjust the line-height to
1.2
because it solves the problem without affecting the external layout or adding unnecessary space between elements, as padding would. This keeps the fix more contained and focused on typography.Testing:
Tested at 100% zoom with the 'Ubuntu' font, and the underscores are now visible without layout issues.
Before
###After