Skip to content

Fix long option parsing by using expr instead of arithmetic expansion #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix long option parsing by using expr instead of arithmetic expansion #88

wants to merge 1 commit into from

Conversation

chenrui333
Copy link

@chenrui333 chenrui333 force-pushed the fix/long-opts-parsing branch from a06bcc1 to 32418e7 Compare July 29, 2025 22:12
@chenrui333 chenrui333 changed the title fix: restore --version and --help on bash 3.2 by pre-parsing long flags Fix long option parsing by using expr instead of arithmetic expansion Jul 29, 2025
@kdabir kdabir self-requested a review August 1, 2025 09:04
kdabir
kdabir approved these changes Aug 1, 2025
View reviewed changes
Copy link
Owner

@kdabir kdabir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. I'll add tests in a separate commit so that this is covered for future.

kdabir
kdabir requested changes Aug 1, 2025
View reviewed changes
Copy link
Owner

@kdabir kdabir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the current changes fail the shellcheck. I am fixing this in master directly and adding some tests. Thank you so much for contributing

@kdabir
Copy link
Owner

kdabir commented Aug 1, 2025

Thanks for suggesting the fix. I could not merge your PR because it was failing shellcheck. However that prompted me to add tests for this and also fix it in a way that shellcheck doesn't complain.

@kdabir kdabir closed this Aug 1, 2025
@kdabir
Copy link
Owner

kdabir commented Aug 1, 2025

https://github.com/kdabir/has/releases/tag/v1.5.2

@chenrui333
Copy link
Author

yeah, that works for me, thanks!

@chenrui333 chenrui333 mentioned this pull request Aug 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdabir kdabir kdabir requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--version and --help options return error
2 participants
@chenrui333 @kdabir