Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Enable more than one Keploy Containers to run simultaenously #2172

Open
wants to merge 36 commits into
base: main
Choose a base branch
from
Open

feat: Enable more than one Keploy Containers to run simultaenously #2172

wants to merge 36 commits into from

Conversation

khareyash05
Copy link
Contributor

@khareyash05 khareyash05 commented Aug 2, 2024 •
edited
Loading

Closes #2206

Describe the changes you've made

  1. Run More than one keploy containers in parallel , creating keploy containers with random uuid's
  2. Fix Debugfs deletion in case of debugfs in use
  3. Make keploy container name configurable and dynamic wrt to container
  4. Allow to Gracefully exit from a Docker Container in case of Exit Status 143
  5. Allow Dynamic Proxy Ports

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Please let us know if any test cases are added

Please describe the tests(if any). Provide instructions how its affecting the coverage.

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

A clear and concise description of it.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Screenshots (if any)

Original Updated
original screenshot updated screenshot

@khareyash05 khareyash05 marked this pull request as ready for review August 5, 2024 06:27
@khareyash05 khareyash05 mentioned this pull request Aug 5, 2024
Closed
5 tasks
@khareyash05 khareyash05 changed the title feat: run more than one keploy containers feat: Enable more than one Keploy Containers to run simultaenously Aug 6, 2024
@khareyash05 khareyash05 self-assigned this Aug 6, 2024
charankamarapu
charankamarapu requested changes Aug 14, 2024
View reviewed changes
Copy link
Member

@charankamarapu charankamarapu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please address the comments. You can also add logic of generating random keploy container name if the name from the config is conflicting with any other container.

cli/provider/docker.go Outdated Show resolved Hide resolved
cli/provider/docker.go Outdated Show resolved Hide resolved
cli/provider/docker.go Outdated Show resolved Hide resolved
cli/provider/docker.go
logger.Info("Command terminated with exit code 143 (SIGTERM), treating as successful exit")
return nil
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we now give exit code 1 if the tests cases fail we need to handle this properly around keploy binary and keploy docker communication.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making another condition to send a debug log with exit code 1

@charankamarapu
Copy link
Member

will review by this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charankamarapu charankamarapu Awaiting requested review from charankamarapu

Requested changes must be addressed to merge this pull request.

Assignees

@khareyash05 khareyash05

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug]: Docker issue when Running more than one Keploy Containers simultaneously
2 participants
@khareyash05 @charankamarapu